Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 04:02:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

coccinelle: Remove unnecessary parentheses for only one possible change.

Browse Source 
The parentheses are only needed if there is a disjunction, ie a
set of possible changes. If there is only one pattern, we can
remove these parentheses. Just like the format:

  -  x
  +  y

not:

  (
  -  x
  +  y
  )

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
This commit is contained in:
Hongbo Li 2024-09-11 09:09:27 +08:00 committed by Julia Lawall
parent 253244cdf1
commit f584e3752c
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/coccinelle/api/string_choices.cocci
View File

@ -43,18 +43,14 @@ coccilib.report.print_report(p[0], "opportunity for str_plural(%s)" % e)
@str_up_down depends on patch@ @str_up_down depends on patch@
expression E; expression E;
@@ @@
(
- ((E) ? "up" : "down") - ((E) ? "up" : "down")
+ str_up_down(E) + str_up_down(E)
)
@str_up_down_r depends on !patch exists@ @str_up_down_r depends on !patch exists@
expression E; expression E;
position P; position P;
@@ @@
(
* ((E@P) ? "up" : "down") * ((E@P) ? "up" : "down")
)
@script:python depends on report@ @script:python depends on report@
p << str_up_down_r.P; p << str_up_down_r.P;
@ -66,18 +62,14 @@ coccilib.report.print_report(p[0], "opportunity for str_up_down(%s)" % e)
@str_down_up depends on patch@ @str_down_up depends on patch@
expression E; expression E;
@@ @@
(
- ((E) ? "down" : "up") - ((E) ? "down" : "up")
+ str_down_up(E) + str_down_up(E)
)
@str_down_up_r depends on !patch exists@ @str_down_up_r depends on !patch exists@
expression E; expression E;
position P; position P;
@@ @@
(
* ((E@P) ? "down" : "up") * ((E@P) ? "down" : "up")
)
@script:python depends on report@ @script:python depends on report@
p << str_down_up_r.P; p << str_down_up_r.P;