Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-24 14:10:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

blk-throttle: correct stale comment in throtl_pd_init

Browse Source 
On the default hierarchy (cgroup2), the throttle interface files don't
exist in the root cgroup, so the ablity to limit the whole system
by configuring root group is not existing anymore. In general, cgroup
doesn't wanna be in the business of restricting resources at the
system level, so correct the stale comment that we can limit whole
system to we can only limit subtree.

Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
Link: https://lore.kernel.org/r/20221205115709.251489-2-shikemeng@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Kemeng Shi 2022-12-05 19:57:01 +08:00 committed by Jens Axboe
parent b147645148
commit f56019aef3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
block/blk-throttle.c
View File

@ -395,8 +395,9 @@ static void throtl_pd_init(struct blkg_policy_data *pd)
* If on the default hierarchy, we switch to properly hierarchical * If on the default hierarchy, we switch to properly hierarchical
* behavior where limits on a given throtl_grp are applied to the * behavior where limits on a given throtl_grp are applied to the
* whole subtree rather than just the group itself. e.g. If 16M * whole subtree rather than just the group itself. e.g. If 16M
* read_bps limit is set on the root group, the whole system can't * read_bps limit is set on a parent group, summary bps of
* exceed 16M for the device. * parent group and its subtree groups can't exceed 16M for the
* device.
* *
* If not on the default hierarchy, the broken flat hierarchy * If not on the default hierarchy, the broken flat hierarchy
* behavior is retained where all throtl_grps are treated as if * behavior is retained where all throtl_grps are treated as if