Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-25 13:41:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

selftests/bpf: Fix fclose/pclose mismatch in test_progs

Browse Source 
Make sure to use pclose() to properly close the pipe opened by popen().

Fixes: 81f77fd0de ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID")
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20211026143409.42666-1-andrea.righi@canonical.com
This commit is contained in:
Andrea Righi 2021-10-26 16:34:09 +02:00 committed by Daniel Borkmann
parent b9989b5912
commit f48ad69097
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/selftests/bpf/test_progs.c
View File

@ -382,7 +382,7 @@ int extract_build_id(char *build_id, size_t size)
if (getline(&line, &len, fp) == -1)
goto err;
fclose(fp);
pclose(fp);
if (len > size)
len = size;
@ -391,7 +391,7 @@ int extract_build_id(char *build_id, size_t size)
free(line);
return 0;
err:
fclose(fp);
pclose(fp);
return -1;
}