Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-29 15:41:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fsi/fsi-master-gpio: Delay sampling of FSI data input

Browse Source 
Most SoC GPIO implementations, including the Aspeed one, have
synchronizers on the GPIO inputs. This means that the value
read from a GPIO is a couple of clocks old, from whatever clock
source feeds those synchronizers.

In practice, this means that in no-delay mode, we are using a
value that can potentially be a bit too old and too close to
the clock edge establishing the data on the other side of the link.

The voltage converters we use on some systems make this worse
and sensitive to things like voltage fluctuations etc... This is,
we believe, the cause of occasional CRC errors encountered during
heavy activity on the LPC bus.

This is fixed by introducing a dummy GPIO read before the actual
data read. It slows down SBEFIFO by about 15% (less than any delay
primitive) and the end result is so far solid.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Tested-by: Joel Stanley <joel@jms.id.au>
This commit is contained in:
Benjamin Herrenschmidt 2018-05-15 23:05:58 +10:00
parent b632642e4c
commit f3ca4834ac
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/fsi/fsi-master-gpio.c
View File

@ -97,6 +97,11 @@ static int sda_clock_in(struct fsi_master_gpio *master)
if (!master->no_delays) if (!master->no_delays)
ndelay(FSI_GPIO_STD_DLY); ndelay(FSI_GPIO_STD_DLY);
gpiod_set_value(master->gpio_clk, 0); gpiod_set_value(master->gpio_clk, 0);
/* Dummy read to feed the synchronizers */
gpiod_get_value(master->gpio_data);
/* Actual data read */
in = gpiod_get_value(master->gpio_data); in = gpiod_get_value(master->gpio_data);
if (!master->no_delays) if (!master->no_delays)
ndelay(FSI_GPIO_STD_DLY); ndelay(FSI_GPIO_STD_DLY);