Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 04:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools: bpftool: Include common options from separate file

Browse Source 
Nearly all man pages for bpftool have the same common set of option
flags (--help, --version, --json, --pretty, --debug). The description is
duplicated across all the pages, which is more difficult to maintain if
the description of an option changes. It may also be confusing to sort
out what options are not "common" and should not be copied when creating
new manual pages.

Let's move the description for those common options to a separate file,
which is included with a RST directive when generating the man pages.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200909162500.17010-3-quentin@isovalent.com
This commit is contained in:
Quentin Monnet 2020-09-09 17:24:59 +01:00 committed by Alexei Starovoitov
parent 82b8cf0acc
commit f28ef96d7b
14 changed files with 35 additions and 196 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/bpf/bpftool/Documentation/Makefile
View File

@ -19,7 +19,7 @@ man8dir = $(mandir)/man8
# Load targets for building eBPF helpers man page. # Load targets for building eBPF helpers man page.
include ../../Makefile.helpers include ../../Makefile.helpers
MAN8_RST = $(filter-out $(HELPERS_RST),$(wildcard *.rst)) MAN8_RST = $(wildcard bpftool*.rst)
_DOC_MAN8 = $(patsubst %.rst,%.8,$(MAN8_RST)) _DOC_MAN8 = $(patsubst %.rst,%.8,$(MAN8_RST))
DOC_MAN8 = $(addprefix $(OUTPUT),$(_DOC_MAN8)) DOC_MAN8 = $(addprefix $(OUTPUT),$(_DOC_MAN8))

17
tools/bpf/bpftool/Documentation/bpftool-btf.rst
View File

@ -71,22 +71,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
EXAMPLES EXAMPLES
======== ========

17
tools/bpf/bpftool/Documentation/bpftool-cgroup.rst
View File

@ -116,26 +116,11 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-f, --bpffs -f, --bpffs
Show file names of pinned programs. Show file names of pinned programs.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
EXAMPLES EXAMPLES
======== ========
| |

17
tools/bpf/bpftool/Documentation/bpftool-feature.rst
View File

@ -71,22 +71,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
SEE ALSO SEE ALSO
======== ========

17
tools/bpf/bpftool/Documentation/bpftool-gen.rst
View File

@ -126,22 +126,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON,
this option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
EXAMPLES EXAMPLES
======== ========

11
tools/bpf/bpftool/Documentation/bpftool-iter.rst
View File

@ -51,16 +51,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-d, --debug
Print all logs available, even debug-level information. This
includes logs from libbpf as well as from the verifier, when
attempting to load programs.
EXAMPLES EXAMPLES
======== ========

17
tools/bpf/bpftool/Documentation/bpftool-link.rst
View File

@ -62,18 +62,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-f, --bpffs -f, --bpffs
When showing BPF links, show file names of pinned When showing BPF links, show file names of pinned
@ -83,10 +72,6 @@ OPTIONS
Do not automatically attempt to mount any virtual file system Do not automatically attempt to mount any virtual file system
(such as tracefs or BPF virtual file system) when necessary. (such as tracefs or BPF virtual file system) when necessary.
-d, --debug
Print all logs available, even debug-level information. This
includes logs from libbpf.
EXAMPLES EXAMPLES
======== ========
**# bpftool link show** **# bpftool link show**

17
tools/bpf/bpftool/Documentation/bpftool-map.rst
View File

@ -155,18 +155,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-f, --bpffs -f, --bpffs
Show file names of pinned maps. Show file names of pinned maps.
@ -175,10 +164,6 @@ OPTIONS
Do not automatically attempt to mount any virtual file system Do not automatically attempt to mount any virtual file system
(such as tracefs or BPF virtual file system) when necessary. (such as tracefs or BPF virtual file system) when necessary.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
EXAMPLES EXAMPLES
======== ========
**# bpftool map show** **# bpftool map show**

17
tools/bpf/bpftool/Documentation/bpftool-net.rst
View File

@ -75,22 +75,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
EXAMPLES EXAMPLES
======== ========

17
tools/bpf/bpftool/Documentation/bpftool-perf.rst
View File

@ -40,22 +40,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available from libbpf, including debug-level
information.
EXAMPLES EXAMPLES
======== ========

18
tools/bpf/bpftool/Documentation/bpftool-prog.rst
View File

@ -210,18 +210,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-f, --bpffs -f, --bpffs
When showing BPF programs, show file names of pinned When showing BPF programs, show file names of pinned
@ -234,11 +223,6 @@ OPTIONS
Do not automatically attempt to mount any virtual file system Do not automatically attempt to mount any virtual file system
(such as tracefs or BPF virtual file system) when necessary. (such as tracefs or BPF virtual file system) when necessary.
-d, --debug
Print all logs available, even debug-level information. This
includes logs from libbpf as well as from the verifier, when
attempting to load programs.
EXAMPLES EXAMPLES
======== ========
**# bpftool prog show** **# bpftool prog show**

18
tools/bpf/bpftool/Documentation/bpftool-struct_ops.rst
View File

@ -60,23 +60,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short generic help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available, even debug-level information. This
includes logs from libbpf as well as from the verifier, when
attempting to load programs.
EXAMPLES EXAMPLES
======== ========

24
tools/bpf/bpftool/Documentation/bpftool.rst
View File

@ -46,24 +46,7 @@ DESCRIPTION
OPTIONS OPTIONS
======= =======
-h, --help .. include:: common_options.rst
Print short help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**), and
optional features that were included when bpftool was
compiled. Optional features include linking against libbfd to
provide the disassembler for JIT-ted programs (**bpftool prog
dump jited**) and usage of BPF skeletons (some features like
**bpftool prog profile** or showing pids associated to BPF
objects may rely on it).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-m, --mapcompat -m, --mapcompat
Allow loading maps with unknown map definitions. Allow loading maps with unknown map definitions.
@ -72,11 +55,6 @@ OPTIONS
Do not automatically attempt to mount any virtual file system Do not automatically attempt to mount any virtual file system
(such as tracefs or BPF virtual file system) when necessary. (such as tracefs or BPF virtual file system) when necessary.
-d, --debug
Print all logs available, even debug-level information. This
includes logs from libbpf as well as from the verifier, when
attempting to load programs.
SEE ALSO SEE ALSO
======== ========
**bpf**\ (2), **bpf**\ (2),

22
tools/bpf/bpftool/Documentation/common_options.rst Normal file
View File

@ -0,0 +1,22 @@
-h, --help
Print short help message (similar to **bpftool help**).
-V, --version
Print version number (similar to **bpftool version**), and optional
features that were included when bpftool was compiled. Optional
features include linking against libbfd to provide the disassembler
for JIT-ted programs (**bpftool prog dump jited**) and usage of BPF
skeletons (some features like **bpftool prog profile** or showing
pids associated to BPF objects may rely on it).
-j, --json
Generate JSON output. For commands that cannot produce JSON, this
option has no effect.
-p, --pretty
Generate human-readable JSON output. Implies **-j**.
-d, --debug
Print all logs available, even debug-level information. This includes
logs from libbpf as well as from the verifier, when attempting to
load programs.