Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 14:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe

Browse Source 
Smatch reports:
1. mtk_thermal_probe() warn: 'apmixed_base' from of_iomap() not released.
2. mtk_thermal_probe() warn: 'auxadc_base' from of_iomap() not released.

The original code forgets to release iomap resource when handling errors,
fix it by switch to devm_of_iomap.

Fixes: 89945047b1 ("thermal: mediatek: Add tsensor support for V2 thermal system")
Signed-off-by: Kang Chen <void0red@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230419020749.621257-1-void0red@hust.edu.cn
This commit is contained in:
Kang Chen 2023-04-19 10:07:48 +08:00 committed by Daniel Lezcano
parent 47cbb0467b
commit f05c7b7d9e
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/thermal/mediatek/auxadc_thermal.c
View File

@ -1232,7 +1232,12 @@ static int mtk_thermal_probe(struct platform_device *pdev)
return -ENODEV; return -ENODEV;
} }
auxadc_base = of_iomap(auxadc, 0); auxadc_base = devm_of_iomap(&pdev->dev, auxadc, 0, NULL);
if (IS_ERR(auxadc_base)) {
of_node_put(auxadc);
return PTR_ERR(auxadc_base);
}
auxadc_phys_base = of_get_phys_base(auxadc); auxadc_phys_base = of_get_phys_base(auxadc);
of_node_put(auxadc); of_node_put(auxadc);
@ -1248,7 +1253,12 @@ static int mtk_thermal_probe(struct platform_device *pdev)
return -ENODEV; return -ENODEV;
} }
apmixed_base = of_iomap(apmixedsys, 0); apmixed_base = devm_of_iomap(&pdev->dev, apmixedsys, 0, NULL);
if (IS_ERR(apmixed_base)) {
of_node_put(apmixedsys);
return PTR_ERR(apmixed_base);
}
apmixed_phys_base = of_get_phys_base(apmixedsys); apmixed_phys_base = of_get_phys_base(apmixedsys);
of_node_put(apmixedsys); of_node_put(apmixedsys);