Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-01 16:41:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf sched: Fix memory leak in perf_sched__map()

Browse Source 
perf_sched__map() needs to free memory of map_cpus, color_pids and
color_cpus in normal path and rollback allocated memory in error path.

Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240206083228.172607-3-yangjihong1@huawei.com
This commit is contained in:
Yang Jihong 2024-02-06 08:32:25 +00:00 committed by Namhyung Kim
parent c690786351
commit ef76a5af81
1 changed files with 26 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
tools/perf/builtin-sched.c
View File

@ -3208,8 +3208,6 @@ static int perf_sched__lat(struct perf_sched *sched)
static int setup_map_cpus(struct perf_sched *sched)
{
struct perf_cpu_map *map;
sched->max_cpu.cpu = sysconf(_SC_NPROCESSORS_CONF);
if (sched->map.comp) {
@ -3218,16 +3216,15 @@ static int setup_map_cpus(struct perf_sched *sched)
return -1;
}
if (!sched->map.cpus_str)
return 0;
map = perf_cpu_map__new(sched->map.cpus_str);
if (!map) {
pr_err("failed to get cpus map from %s\n", sched->map.cpus_str);
return -1;
if (sched->map.cpus_str) {
sched->map.cpus = perf_cpu_map__new(sched->map.cpus_str);
if (!sched->map.cpus) {
pr_err("failed to get cpus map from %s\n", sched->map.cpus_str);
zfree(&sched->map.comp_cpus);
return -1;
}
}
sched->map.cpus = map;
return 0;
}
@ -3267,20 +3264,34 @@ static int setup_color_cpus(struct perf_sched *sched)
static int perf_sched__map(struct perf_sched *sched)
{
int rc = -1;
if (setup_map_cpus(sched))
return -1;
return rc;
if (setup_color_pids(sched))
return -1;
goto out_put_map_cpus;
if (setup_color_cpus(sched))
return -1;
goto out_put_color_pids;
setup_pager();
if (perf_sched__read_events(sched))
return -1;
goto out_put_color_cpus;
rc = 0;
print_bad_events(sched);
return 0;
out_put_color_cpus:
perf_cpu_map__put(sched->map.color_cpus);
out_put_color_pids:
perf_thread_map__put(sched->map.color_pids);
out_put_map_cpus:
zfree(&sched->map.comp_cpus);
perf_cpu_map__put(sched->map.cpus);
return rc;
}
static int perf_sched__replay(struct perf_sched *sched)