Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-25 05:32:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

[LIB] crc32c: Keep intermediate crc state in cpu order

Browse Source 
crypto/crc32.c:chksum_final() is computing the digest as
*(__le32 *)out = ~cpu_to_le32(mctx->crc);
so the low-level crc32c_le routines should just keep
the crc in cpu order, otherwise it is getting swabbed
one too many times on big-endian machines.

Signed-off-by: Benny Halevy <bhalevy@fs1.bhalevy.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Benny Halevy 2007-11-08 21:34:09 +08:00 committed by Herbert Xu
parent dbeeb816e8
commit ef19454bd4
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/libcrc32c.c
View File

@ -33,7 +33,6 @@
#include <linux/crc32c.h>
#include <linux/compiler.h>
#include <linux/module.h>
#include <asm/byteorder.h>
MODULE_AUTHOR("Clay Haapala <chaapala@cisco.com>");
MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
@ -161,15 +160,13 @@ static const u32 crc32c_table[256] = {
*/
u32 __pure
crc32c_le(u32 seed, unsigned char const *data, size_t length)
crc32c_le(u32 crc, unsigned char const *data, size_t length)
{
u32 crc = __cpu_to_le32(seed);
while (length--)
crc =
crc32c_table[(crc ^ *data++) & 0xFFL] ^ (crc >> 8);
return __le32_to_cpu(crc);
return crc;
}
#endif /* CRC_LE_BITS == 8 */