staging: dgnc: introduce the dgnc_tty_unregister()

The dgnc_tty_unregister() will be called when
the dgnc_tty_register() is failed.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Daeseok Youn 2016-09-26 09:43:51 +09:00 committed by Greg Kroah-Hartman
parent f20ae478ff
commit eea5fd1164
3 changed files with 14 additions and 2 deletions

View File

@ -299,13 +299,13 @@ static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
rc = dgnc_finalize_board_init(brd);
if (rc < 0) {
pr_err(DRVSTR ": Can't finalize board init (%d)\n", rc);
goto failed;
goto unregister_tty;
}
rc = dgnc_tty_init(brd);
if (rc < 0) {
pr_err(DRVSTR ": Can't init tty devices (%d)\n", rc);
goto failed;
goto unregister_tty;
}
brd->state = BOARD_READY;
@ -317,6 +317,9 @@ static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return 0;
unregister_tty:
dgnc_tty_unregister(brd);
failed:
kfree(brd);

View File

@ -273,6 +273,14 @@ free_serial_driver:
return rc;
}
void dgnc_tty_unregister(struct dgnc_board *brd)
{
tty_unregister_driver(brd->print_driver);
tty_unregister_driver(brd->serial_driver);
put_tty_driver(brd->print_driver);
put_tty_driver(brd->serial_driver);
}
/*
* dgnc_tty_init()
*

View File

@ -19,6 +19,7 @@
#include "dgnc_driver.h"
int dgnc_tty_register(struct dgnc_board *brd);
void dgnc_tty_unregister(struct dgnc_board *brd);
int dgnc_tty_preinit(void);
int dgnc_tty_init(struct dgnc_board *);