Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-01 17:51:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NETFILTER]: nfnetlink_log: fix reference leak

Browse Source 
Stop reference leaking in nfulnl_log_packet(). If we start a timer we
are already taking another reference.

Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Michal Miroslaw 2007-03-04 15:58:15 -08:00 committed by David S. Miller
parent d3ab4298aa
commit ed32abeaf3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/netfilter/nfnetlink_log.c
View File

@ -711,15 +711,16 @@ nfulnl_log_packet(unsigned int pf,
inst->timer.expires = jiffies + (inst->flushtimeout*HZ/100); inst->timer.expires = jiffies + (inst->flushtimeout*HZ/100);
add_timer(&inst->timer); add_timer(&inst->timer);
} }
spin_unlock_bh(&inst->lock);
unlock_and_release:
spin_unlock_bh(&inst->lock);
instance_put(inst);
return; return;
alloc_failure: alloc_failure:
spin_unlock_bh(&inst->lock);
instance_put(inst);
UDEBUG("error allocating skb\n"); UDEBUG("error allocating skb\n");
/* FIXME: statistics */ /* FIXME: statistics */
goto unlock_and_release;
} }
static int static int