Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-26 23:12:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[media] m88ds3103: fix undefined division

Browse Source 
s32tmp in the below code may be negative, and dev->mclk_khz is an
unsigned type.

	s32tmp = 0x10000 * (tuner_frequency - c->frequency);
	s32tmp = DIV_ROUND_CLOSEST(s32tmp, dev->mclk_khz);

This is undefined, as DIV_ROUND_CLOSEST is undefined for negative
dividends when the divisor is of unsigned type.

So, change mclk_khz to be signed (s32).

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Peter Rosin 2016-03-16 09:14:13 -03:00 committed by Mauro Carvalho Chehab
parent 71c5daba05
commit ecb7b0183a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/dvb-frontends/m88ds3103_priv.h
View File

@ -46,7 +46,7 @@ struct m88ds3103_dev {
/* auto detect chip id to do different config */ /* auto detect chip id to do different config */
u8 chip_id; u8 chip_id;
/* main mclk is calculated for M88RS6000 dynamically */ /* main mclk is calculated for M88RS6000 dynamically */
u32 mclk_khz; s32 mclk_khz;
u64 post_bit_error; u64 post_bit_error;
u64 post_bit_count; u64 post_bit_count;
}; };