Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-07 04:32:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: sbe-2t3e3: remove t3e3_resp_t typedef

Browse Source 
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_resp_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/ctrl.h:123: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kristina Martšenko 2014-03-03 23:05:46 +02:00 committed by Greg Kroah-Hartman
parent c6a297bcb1
commit eb55b5b480
4 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/sbe-2t3e3/2t3e3.h
View File

@ -760,8 +760,7 @@ void t3e3_init(struct channel *);
void t3e3_if_up(struct channel *);
void t3e3_if_down(struct channel *);
int t3e3_if_start_xmit(struct sk_buff *skb, struct net_device *dev);
void t3e3_if_config(struct channel *, u32, char *,
t3e3_resp_t *, int *);
void t3e3_if_config(struct channel *, u32, char *, struct t3e3_resp *, int *);
void t3e3_set_frame_type(struct channel *, u32);
u32 t3e3_eeprom_read_word(struct channel *, u32);
void t3e3_read_card_serial_number(struct channel *);

2
drivers/staging/sbe-2t3e3/ctrl.c
View File

@ -287,7 +287,7 @@ static void t3e3_port_del_stats(struct channel *sc)
}
void t3e3_if_config(struct channel *sc, u32 cmd, char *set,
t3e3_resp_t *ret, int *rlen)
struct t3e3_resp *ret, int *rlen)
{
struct t3e3_param *param = (struct t3e3_param *)set;
u32 *data = (u32 *)set;

4
drivers/staging/sbe-2t3e3/ctrl.h
View File

@ -120,12 +120,12 @@ struct t3e3_stats {
};
typedef struct t3e3_resp {
struct t3e3_resp {
union {
struct t3e3_param param;
struct t3e3_stats stats;
u32 data;
} u;
} t3e3_resp_t;
};
#endif /* CTRL_H */

2
drivers/staging/sbe-2t3e3/netdev.c
View File

@ -26,7 +26,7 @@ static int t3e3_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
struct channel *sc = dev_to_priv(dev);
int cmd_2t3e3, len, rlen;
struct t3e3_param param;
t3e3_resp_t resp;
struct t3e3_resp resp;
void __user *data = ifr->ifr_data + sizeof(cmd_2t3e3) + sizeof(len);
if (cmd == SIOCWANDEV)