Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-18 00:53:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

RDS/IB: Do not wait for send ring to be empty on conn shutdown

Browse Source 
Now that we are signaling send completions much less, we are likely
to have dirty entries in the send queue when the connection is
shut down (on rmmod, for example.) These are cleaned up a little
further down in conn_shutdown, but if we wait on the ring_empty_wait
for them, it'll never happen, and we hand on unload.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
This commit is contained in:
Andy Grover 2010-03-03 19:25:21 -08:00
parent ff3d7d3613
commit e32b4a7049
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/rds/ib_cm.c
View File

@ -620,8 +620,11 @@ void rds_ib_conn_shutdown(struct rds_connection *conn)
ic->i_cm_id, err); ic->i_cm_id, err);
} }
/*
* Don't wait for the send ring to be empty -- there may be completed
* non-signaled entries sitting on there. We unmap these below.
*/
wait_event(rds_ib_ring_empty_wait, wait_event(rds_ib_ring_empty_wait,
rds_ib_ring_empty(&ic->i_send_ring) &&
rds_ib_ring_empty(&ic->i_recv_ring)); rds_ib_ring_empty(&ic->i_recv_ring));
if (ic->i_send_hdrs) if (ic->i_send_hdrs)