mirror of
https://github.com/torvalds/linux.git
synced 2024-12-05 18:41:23 +00:00
media: atmel: atmel-isc-base: use streaming status when queueing buffers
During experiments with libcamera, it looks like vb2_is_streaming returns true before our start streaming is called. Order of operations is streamon -> queue -> start_streaming ISC would have started the DMA immediately when a buffer is being added to the vbqueue if the queue is streaming. It is more safe to start the DMA after the start streaming of the driver is called. Thus, even if vb2queue is streaming, add the buffer to the dma queue of the driver instead of actually starting the DMA process, if the start streaming has not been called yet. Tho achieve this, we have to use vb2_start_streaming_called instead of vb2_is_streaming. Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
parent
5f25abec8f
commit
e0cf8b9e3a
@ -442,7 +442,7 @@ static void isc_buffer_queue(struct vb2_buffer *vb)
|
||||
|
||||
spin_lock_irqsave(&isc->dma_queue_lock, flags);
|
||||
if (!isc->cur_frm && list_empty(&isc->dma_queue) &&
|
||||
vb2_is_streaming(vb->vb2_queue)) {
|
||||
vb2_start_streaming_called(vb->vb2_queue)) {
|
||||
isc->cur_frm = buf;
|
||||
isc_start_dma(isc);
|
||||
} else
|
||||
|
Loading…
Reference in New Issue
Block a user