Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 20:22:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

iommu/mtk: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230321084125.337021-8-u.kleine-koenig@pengutronix.de
Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Uwe Kleine-König 2023-03-21 09:41:22 +01:00 committed by Joerg Roedel
parent 816a4afce1
commit d8149d3929
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/iommu/mtk_iommu.c
View File

@ -1316,7 +1316,7 @@ out_runtime_disable:
return ret; return ret;
} }
static int mtk_iommu_remove(struct platform_device *pdev) static void mtk_iommu_remove(struct platform_device *pdev)
{ {
struct mtk_iommu_data *data = platform_get_drvdata(pdev); struct mtk_iommu_data *data = platform_get_drvdata(pdev);
struct mtk_iommu_bank_data *bank; struct mtk_iommu_bank_data *bank;
@ -1338,7 +1338,6 @@ static int mtk_iommu_remove(struct platform_device *pdev)
continue; continue;
devm_free_irq(&pdev->dev, bank->irq, bank); devm_free_irq(&pdev->dev, bank->irq, bank);
} }
return 0;
} }
static int __maybe_unused mtk_iommu_runtime_suspend(struct device *dev) static int __maybe_unused mtk_iommu_runtime_suspend(struct device *dev)
@ -1595,7 +1594,7 @@ static const struct of_device_id mtk_iommu_of_ids[] = {
static struct platform_driver mtk_iommu_driver = { static struct platform_driver mtk_iommu_driver = {
.probe = mtk_iommu_probe, .probe = mtk_iommu_probe,
.remove = mtk_iommu_remove, .remove_new = mtk_iommu_remove,
.driver = { .driver = {
.name = "mtk-iommu", .name = "mtk-iommu",
.of_match_table = mtk_iommu_of_ids, .of_match_table = mtk_iommu_of_ids,