mirror of
https://github.com/torvalds/linux.git
synced 2024-11-06 20:21:57 +00:00
tipc: fix out of bounds indexing
Commit 78acb1f9b8
("tipc: add
ioctl to fetch link names") introduced a buffer overflow bug where
specially crafted ioctl requests could cause out-of-bounds indexing
of the node->links array. This was caused by an incorrect check vs
MAX_BEARERS, and the static code checker complaint is:
net/tipc/node.c:459 tipc_node_get_linkname() error: buffer overflow 'node->links' 2 <= 2
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
d37556eb1c
commit
d7bb74c38c
@ -453,7 +453,7 @@ int tipc_node_get_linkname(u32 bearer_id, u32 addr, char *linkname, size_t len)
|
||||
struct tipc_link *link;
|
||||
struct tipc_node *node = tipc_node_find(addr);
|
||||
|
||||
if ((bearer_id > MAX_BEARERS) || !node)
|
||||
if ((bearer_id >= MAX_BEARERS) || !node)
|
||||
return -EINVAL;
|
||||
tipc_node_lock(node);
|
||||
link = node->links[bearer_id];
|
||||
|
Loading…
Reference in New Issue
Block a user