mirror of
https://github.com/torvalds/linux.git
synced 2024-12-06 19:11:31 +00:00
gpio: mvebu: clear irq in edge cause register before unmask edge irq
When input GPIO set from 0 to 1, the interrupt bit asserted in the GPIO Interrupt Cause Register (ICR) even if the corresponding interrupt masked in the GPIO Interrupt Mask Register. Because interrupt mask register only affects assertion of the interrupt bits in Main Interrupt Cause Register and it does not affect the setting of bits in the GPIO ICR. So, there is problem, when we unmask interrupt with already asserted bit in the GPIO ICR, then false interrupt immediately occurs even if GPIO don't change their value since last unmask. Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> Link: https://lore.kernel.org/r/20200115073811.24438-1-bigunclemax@gmail.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
366950eeb6
commit
d5331ec2cc
@ -431,6 +431,7 @@ static void mvebu_gpio_edge_irq_unmask(struct irq_data *d)
|
||||
u32 mask = d->mask;
|
||||
|
||||
irq_gc_lock(gc);
|
||||
mvebu_gpio_write_edge_cause(mvchip, ~mask);
|
||||
ct->mask_cache_priv |= mask;
|
||||
mvebu_gpio_write_edge_mask(mvchip, ct->mask_cache_priv);
|
||||
irq_gc_unlock(gc);
|
||||
|
Loading…
Reference in New Issue
Block a user