Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-11 05:33:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf symbols: Fix a memory leak due to symbol__delete not being used

Browse Source 
In function symbols__fixup_duplicate(), while duplicated symbols are
found, only the rb_node is removed from the tree. The symbol structures
themself are ignored.  Then, these memory areas are lost.

Signed-off-by: Chenggang Qin <chenggang.qcg@taobao.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Yanmin Zhang <yanmin.zhang@intel.com>
Link: http://lkml.kernel.org/r/1381451279-4109-3-git-send-email-chenggang.qin@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Chenggang Qin 2013-10-11 08:27:59 +08:00 committed by Arnaldo Carvalho de Melo
parent 1d5077bdd9
commit d4f74eb891
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/util/symbol.c
View File

@ -160,10 +160,12 @@ again:
if (choose_best_symbol(curr, next) == SYMBOL_A) { if (choose_best_symbol(curr, next) == SYMBOL_A) {
rb_erase(&next->rb_node, symbols); rb_erase(&next->rb_node, symbols);
symbol__delete(next);
goto again; goto again;
} else { } else {
nd = rb_next(&curr->rb_node); nd = rb_next(&curr->rb_node);
rb_erase(&curr->rb_node, symbols); rb_erase(&curr->rb_node, symbols);
symbol__delete(curr);
} }
} }
} }