Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-04 10:01:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: das16m1: minor cleanup to das16m1_ai_insn_read()

Browse Source 
The (*insn_read) functions return the number of data values read. The 'n'
value is correct but for clarity change the return to 'insn->n'.

For aesthetics, change the 'n' loop variable name to 'i'. That's more common
in comedi drivers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2016-05-03 12:30:00 -07:00 committed by Greg Kroah-Hartman
parent b31cf31264
commit d0e50e6588
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/comedi/drivers/das16m1.c
View File

@ -324,11 +324,11 @@ static int das16m1_ai_insn_read(struct comedi_device *dev,
unsigned int *data)
{
int ret;
int n;
int i;
das16m1_ai_set_queue(dev, &insn->chanspec, 1);
for (n = 0; n < insn->n; n++) {
for (i = 0; i < insn->n; i++) {
unsigned short val;
/* clear interrupt */
@ -341,10 +341,10 @@ static int das16m1_ai_insn_read(struct comedi_device *dev,
return ret;
val = inw(dev->iobase + DAS16M1_AI_REG);
data[n] = DAS16M1_AI_TO_SAMPLE(val);
data[i] = DAS16M1_AI_TO_SAMPLE(val);
}
return n;
return insn->n;
}
static int das16m1_di_insn_bits(struct comedi_device *dev,