Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 06:02:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

firmware: smccc: Fix use of uninitialised results structure

Browse Source 
Commit 35727af2b1 ("irqchip/gicv3: Workaround for NVIDIA erratum
T241-FABRIC-4") moved the initialisation of the SoC version to
arm_smccc_version_init() but forgot to update the results structure
and it's usage.

Fix the use of the uninitialised results structure and update the
error strings.

Fixes: 35727af2b1 ("irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4")
Signed-off-by: Punit Agrawal <punit.agrawal@bytedance.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Vikram Sethi <vsethi@nvidia.com>
Cc: Shanker Donthineni <sdonthineni@nvidia.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230717171702.424253-1-punit.agrawal@bytedance.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
This commit is contained in:
Punit Agrawal 2023-07-17 18:17:02 +01:00 committed by Sudeep Holla
parent 06c2afb862
commit d05799d7b4
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/firmware/smccc/soc_id.c
View File

@ -34,7 +34,6 @@ static struct soc_device_attribute *soc_dev_attr;
static int __init smccc_soc_init(void) static int __init smccc_soc_init(void)
{ {
struct arm_smccc_res res;
int soc_id_rev, soc_id_version; int soc_id_rev, soc_id_version;
static char soc_id_str[20], soc_id_rev_str[12]; static char soc_id_str[20], soc_id_rev_str[12];
static char soc_id_jep106_id_str[12]; static char soc_id_jep106_id_str[12];
@ -49,13 +48,13 @@ static int __init smccc_soc_init(void)
} }
if (soc_id_version < 0) { if (soc_id_version < 0) {
pr_err("ARCH_SOC_ID(0) returned error: %lx\n", res.a0); pr_err("Invalid SoC Version: %x\n", soc_id_version);
return -EINVAL; return -EINVAL;
} }
soc_id_rev = arm_smccc_get_soc_id_revision(); soc_id_rev = arm_smccc_get_soc_id_revision();
if (soc_id_rev < 0) { if (soc_id_rev < 0) {
pr_err("ARCH_SOC_ID(1) returned error: %lx\n", res.a0); pr_err("Invalid SoC Revision: %x\n", soc_id_rev);
return -EINVAL; return -EINVAL;
} }