mirror of
https://github.com/torvalds/linux.git
synced 2024-11-24 05:02:12 +00:00
ARM: OMAP: SmartReflex: fix error path in init function
Fix the error handling path in omap_sr_probe to correctly de-allocate resources in case of problems. Signed-off-by: Jean Pihet <j-pihet@ti.com> Signed-off-by: Kevin Hilman <khilman@ti.com>
This commit is contained in:
parent
70071ff989
commit
ce3810cdb4
@ -928,7 +928,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
|
||||
if (!sr_info->base) {
|
||||
dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
|
||||
ret = -ENOMEM;
|
||||
goto err_release_region;
|
||||
goto err_free_name;
|
||||
}
|
||||
|
||||
if (irq)
|
||||
@ -967,7 +967,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
|
||||
dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n",
|
||||
__func__);
|
||||
ret = PTR_ERR(sr_info->dbg_dir);
|
||||
goto err_free_name;
|
||||
goto err_debugfs;
|
||||
}
|
||||
|
||||
(void) debugfs_create_file("autocomp", S_IRUGO | S_IWUSR,
|
||||
@ -1011,11 +1011,11 @@ static int __init omap_sr_probe(struct platform_device *pdev)
|
||||
|
||||
err_debugfs:
|
||||
debugfs_remove_recursive(sr_info->dbg_dir);
|
||||
err_free_name:
|
||||
kfree(sr_info->name);
|
||||
err_iounmap:
|
||||
list_del(&sr_info->node);
|
||||
iounmap(sr_info->base);
|
||||
err_free_name:
|
||||
kfree(sr_info->name);
|
||||
err_release_region:
|
||||
release_mem_region(mem->start, resource_size(mem));
|
||||
err_free_devinfo:
|
||||
|
Loading…
Reference in New Issue
Block a user