blk-mq: Make blk_mq_quiesce_tagset() hold the tag list mutex less long

Make sure that the tag_list_lock mutex is not held any longer than
necessary. This change reduces latency if e.g. blk_mq_quiesce_tagset()
is called concurrently from more than one thread. This function is used
by the NVMe core and also by the UFS driver.

Reported-by: Peter Wang <peter.wang@mediatek.com>
Cc: Chao Leng <lengchao@huawei.com>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: stable@vger.kernel.org
Fixes: 414dd48e88 ("blk-mq: add tagset quiesce interface")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20241022181617.2716173-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Bart Van Assche 2024-10-22 11:16:17 -07:00 committed by Jens Axboe
parent 904ebd2527
commit ccd9e252c5

View File

@ -283,8 +283,9 @@ void blk_mq_quiesce_tagset(struct blk_mq_tag_set *set)
if (!blk_queue_skip_tagset_quiesce(q)) if (!blk_queue_skip_tagset_quiesce(q))
blk_mq_quiesce_queue_nowait(q); blk_mq_quiesce_queue_nowait(q);
} }
blk_mq_wait_quiesce_done(set);
mutex_unlock(&set->tag_list_lock); mutex_unlock(&set->tag_list_lock);
blk_mq_wait_quiesce_done(set);
} }
EXPORT_SYMBOL_GPL(blk_mq_quiesce_tagset); EXPORT_SYMBOL_GPL(blk_mq_quiesce_tagset);