mirror of
https://github.com/torvalds/linux.git
synced 2024-11-24 05:02:12 +00:00
gpio: moxart: Avoid forward declaration
Slightly adjust the code to avoid forward declaration as we need to call moxart_gpio_set() in moxart_gpio_direction_output() to properly set the output state. Signed-off-by: Axel Lin <axel.lin@ingics.com> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
a585f87c86
commit
c9e8dbadb0
@ -48,6 +48,31 @@ static void moxart_gpio_free(struct gpio_chip *chip, unsigned offset)
|
||||
pinctrl_free_gpio(offset);
|
||||
}
|
||||
|
||||
static void moxart_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
|
||||
{
|
||||
struct moxart_gpio_chip *gc = to_moxart_gpio(chip);
|
||||
void __iomem *ioaddr = gc->base + GPIO_DATA_OUT;
|
||||
u32 reg = readl(ioaddr);
|
||||
|
||||
if (value)
|
||||
reg = reg | BIT(offset);
|
||||
else
|
||||
reg = reg & ~BIT(offset);
|
||||
|
||||
writel(reg, ioaddr);
|
||||
}
|
||||
|
||||
static int moxart_gpio_get(struct gpio_chip *chip, unsigned offset)
|
||||
{
|
||||
struct moxart_gpio_chip *gc = to_moxart_gpio(chip);
|
||||
u32 ret = readl(gc->base + GPIO_PIN_DIRECTION);
|
||||
|
||||
if (ret & BIT(offset))
|
||||
return !!(readl(gc->base + GPIO_DATA_OUT) & BIT(offset));
|
||||
else
|
||||
return !!(readl(gc->base + GPIO_DATA_IN) & BIT(offset));
|
||||
}
|
||||
|
||||
static int moxart_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
|
||||
{
|
||||
struct moxart_gpio_chip *gc = to_moxart_gpio(chip);
|
||||
@ -67,32 +92,6 @@ static int moxart_gpio_direction_output(struct gpio_chip *chip,
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void moxart_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
|
||||
{
|
||||
struct moxart_gpio_chip *gc = to_moxart_gpio(chip);
|
||||
void __iomem *ioaddr = gc->base + GPIO_DATA_OUT;
|
||||
u32 reg = readl(ioaddr);
|
||||
|
||||
if (value)
|
||||
reg = reg | BIT(offset);
|
||||
else
|
||||
reg = reg & ~BIT(offset);
|
||||
|
||||
|
||||
writel(reg, ioaddr);
|
||||
}
|
||||
|
||||
static int moxart_gpio_get(struct gpio_chip *chip, unsigned offset)
|
||||
{
|
||||
struct moxart_gpio_chip *gc = to_moxart_gpio(chip);
|
||||
u32 ret = readl(gc->base + GPIO_PIN_DIRECTION);
|
||||
|
||||
if (ret & BIT(offset))
|
||||
return !!(readl(gc->base + GPIO_DATA_OUT) & BIT(offset));
|
||||
else
|
||||
return !!(readl(gc->base + GPIO_DATA_IN) & BIT(offset));
|
||||
}
|
||||
|
||||
static struct gpio_chip moxart_template_chip = {
|
||||
.label = "moxart-gpio",
|
||||
.request = moxart_gpio_request,
|
||||
|
Loading…
Reference in New Issue
Block a user