mirror of
https://github.com/torvalds/linux.git
synced 2024-12-01 00:21:32 +00:00
media: rc: iguanair: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293
("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
d1cb98caac
commit
c8efa2c826
@ -76,7 +76,7 @@ struct send_packet {
|
||||
uint8_t channels;
|
||||
uint8_t busy7;
|
||||
uint8_t busy4;
|
||||
uint8_t payload[0];
|
||||
uint8_t payload[];
|
||||
};
|
||||
|
||||
static void process_ir_data(struct iguanair *ir, unsigned len)
|
||||
|
Loading…
Reference in New Issue
Block a user