Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-28 22:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: gadget: pch_udc: Fix wrong return value

Browse Source 
ISSUE:
If the return value of pch_udc_pcd_init() is False, the return value of
this function is unsettled.
Since pch_udc_pcd_init() always returns 0, there is not actually the issue.

CAUSE:
If pch_udc_pcd_init() is True, the variable, retval, is not set for an
appropriate value.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Tomoya MORINAGA 2012-01-12 11:27:06 +09:00 committed by Felipe Balbi
parent c50a3bff0e
commit c802672cd3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/pch_udc.c
View File

@ -2915,8 +2915,10 @@ static int pch_udc_probe(struct pci_dev *pdev,
} }
pch_udc = dev; pch_udc = dev;
/* initialize the hardware */ /* initialize the hardware */
if (pch_udc_pcd_init(dev)) if (pch_udc_pcd_init(dev)) {
retval = -ENODEV;
goto finished; goto finished;
}
if (request_irq(pdev->irq, pch_udc_isr, IRQF_SHARED, KBUILD_MODNAME, if (request_irq(pdev->irq, pch_udc_isr, IRQF_SHARED, KBUILD_MODNAME,
dev)) { dev)) {
dev_err(&pdev->dev, "%s: request_irq(%d) fail\n", __func__, dev_err(&pdev->dev, "%s: request_irq(%d) fail\n", __func__,