Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-11 21:52:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

RDMA/rxe: Replace __rxe_do_task by rxe_run_task

Browse Source 
In rxe_req.c replace calls to __rxe_do_task() by calls to rxe_run_task(..,
0). Using __rxe_do_task is an error because the completer tasklet is not
designed to be re-entrant and __rxe_do_task() should only be called when
it is clear that no one else could be calling the completer tasklet as is
the case in rxe_qp.c where this call is used in safe environments.

Link: https://lore.kernel.org/r/20220630190425.2251-10-rpearsonhpe@gmail.com
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Bob Pearson 2022-06-30 14:04:26 -05:00 committed by Jason Gunthorpe
parent eff6d998ca
commit c2ea08ca5e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/sw/rxe/rxe_req.c
View File

@ -722,7 +722,7 @@ int rxe_requester(void *arg)
qp->req.wqe_index);
wqe->state = wqe_state_done;
wqe->status = IB_WC_SUCCESS;
__rxe_do_task(&qp->comp.task);
rxe_run_task(&qp->comp.task, 0);
goto done;
}
payload = mtu;
@ -803,7 +803,7 @@ done:
goto out;
err:
wqe->state = wqe_state_error;
__rxe_do_task(&qp->comp.task);
rxe_run_task(&qp->comp.task, 0);
exit:
ret = -EAGAIN;
out: