Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fs/sysv: Use dir_put_page() in sysv_rename()

Browse Source 
Use the dir_put_page() helper in sysv_rename() instead of open-coding two
kunmap() + put_page().

Cc: Al Viro <viro@zeniv.linux.org.uk>
Suggested-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Fabio M. De Francesco 2023-01-19 16:32:31 +01:00 committed by Al Viro
parent 8dd6c7b294
commit c26ddc49c9
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/sysv/dir.c
View File

@ -28,7 +28,7 @@ const struct file_operations sysv_dir_operations = {
.fsync = generic_file_fsync,
};
static inline void dir_put_page(struct page *page)
inline void dir_put_page(struct page *page)
{
kunmap(page);
put_page(page);

9
fs/sysv/namei.c
View File

@ -250,13 +250,10 @@ static int sysv_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
return 0;
out_dir:
if (dir_de) {
kunmap(dir_page);
put_page(dir_page);
}
if (dir_de)
dir_put_page(dir_page);
out_old:
kunmap(old_page);
put_page(old_page);
dir_put_page(old_page);
out:
return err;
}

1
fs/sysv/sysv.h
View File

@ -148,6 +148,7 @@ extern void sysv_destroy_icache(void);
/* dir.c */
extern void dir_put_page(struct page *page);
extern struct sysv_dir_entry *sysv_find_entry(struct dentry *, struct page **);
extern int sysv_add_link(struct dentry *, struct inode *);
extern int sysv_delete_entry(struct sysv_dir_entry *, struct page *);