Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-12 06:02:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

pcmcia: avoid static analysis complaint about use-after-free

Browse Source 
Coverity complains about a use after free for 'res1' and 'res2' since
we use the value of the pointers in a 'dev_dbg()' after they have been
freed. That's not really a problem, but it still seems cleaner to
defer freeing until we are completely done with the pointers.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jesper Juhl 2013-01-20 23:14:43 +01:00 committed by Jiri Kosina
parent 4de80273a2
commit bec0b2ce83
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pcmcia/rsrc_nonstatic.c
View File

@ -369,12 +369,12 @@ static int do_validate_mem(struct pcmcia_socket *s,
} }
} }
free_region(res2);
free_region(res1);
dev_dbg(&s->dev, "cs: memory probe 0x%06lx-0x%06lx: %p %p %u %u %u", dev_dbg(&s->dev, "cs: memory probe 0x%06lx-0x%06lx: %p %p %u %u %u",
base, base+size-1, res1, res2, ret, info1, info2); base, base+size-1, res1, res2, ret, info1, info2);
free_region(res2);
free_region(res1);
if ((ret) || (info1 != info2) || (info1 == 0)) if ((ret) || (info1 != info2) || (info1 == 0))
return -EINVAL; return -EINVAL;