mirror of
https://github.com/torvalds/linux.git
synced 2024-11-21 19:41:42 +00:00
rust: specify when ARef
is thread safe
An `ARef` behaves just like the `Arc` when it comes to thread safety, so we can reuse the thread safety comments from `Arc` here. This is necessary because without this change, the Rust compiler will assume that things are not thread safe even though they are. Signed-off-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com> Reviewed-by: Benno Lossin <benno.lossin@proton.me> Link: https://lore.kernel.org/r/20230531145939.3714886-4-aliceryhl@google.com Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This commit is contained in:
parent
d701e061cb
commit
be7724cdbb
@ -321,6 +321,19 @@ pub struct ARef<T: AlwaysRefCounted> {
|
||||
_p: PhantomData<T>,
|
||||
}
|
||||
|
||||
// SAFETY: It is safe to send `ARef<T>` to another thread when the underlying `T` is `Sync` because
|
||||
// it effectively means sharing `&T` (which is safe because `T` is `Sync`); additionally, it needs
|
||||
// `T` to be `Send` because any thread that has an `ARef<T>` may ultimately access `T` using a
|
||||
// mutable reference, for example, when the reference count reaches zero and `T` is dropped.
|
||||
unsafe impl<T: AlwaysRefCounted + Sync + Send> Send for ARef<T> {}
|
||||
|
||||
// SAFETY: It is safe to send `&ARef<T>` to another thread when the underlying `T` is `Sync`
|
||||
// because it effectively means sharing `&T` (which is safe because `T` is `Sync`); additionally,
|
||||
// it needs `T` to be `Send` because any thread that has a `&ARef<T>` may clone it and get an
|
||||
// `ARef<T>` on that thread, so the thread may ultimately access `T` using a mutable reference, for
|
||||
// example, when the reference count reaches zero and `T` is dropped.
|
||||
unsafe impl<T: AlwaysRefCounted + Sync + Send> Sync for ARef<T> {}
|
||||
|
||||
impl<T: AlwaysRefCounted> ARef<T> {
|
||||
/// Creates a new instance of [`ARef`].
|
||||
///
|
||||
|
Loading…
Reference in New Issue
Block a user