Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-27 06:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools/rtla: Enhance argument parsing in timerlat_load.py

Browse Source 
The enhancements made to timerlat_load.py are aimed at improving the clarity of argument parsing.

Summary of Changes:
- The cpu argument is now specified as an integer type in the argument
  parser to enforce input validation, and the construction of affinity_mask
  has been simplified to directly use the integer value of args.cpu.
- The prio argument is similarly updated to be of integer type for
  consistency and validation, eliminating the need for the conversion of
  args.prio to an integer, as this is now handled by the argument parser.

Cc: "jkacur@redhat.com" <jkacur@redhat.com>
Cc: "lgoncalv@redhat.com" <lgoncalv@redhat.com>
Link: https://lore.kernel.org/QfgO7ayKD9dsLk8_ZDebkAV0OF7wla7UmasbP9CBmui_sChOeizy512t3RqCHTjvQoUBUDP8dwEOVCdHQ5KvVNEiP69CynMY94SFDERWl94=@protonmail.com
Signed-off-by: Furkan Onder <furkanonder@protonmail.com>
Reviewed-by: Tomas Glozar <tglozar@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
This commit is contained in:
furkanonder 2024-10-21 15:12:30 +00:00 committed by Steven Rostedt (Google)
parent fc5f5aef9f
commit bd26818343
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/tracing/rtla/sample/timerlat_load.py
View File

@ -25,13 +25,12 @@ import sys
import os import os
parser = argparse.ArgumentParser(description='user-space timerlat thread in Python') parser = argparse.ArgumentParser(description='user-space timerlat thread in Python')
parser.add_argument("cpu", help='CPU to run timerlat thread') parser.add_argument("cpu", type=int, help='CPU to run timerlat thread')
parser.add_argument("-p", "--prio", help='FIFO priority') parser.add_argument("-p", "--prio", type=int, help='FIFO priority')
args = parser.parse_args() args = parser.parse_args()
try: try:
affinity_mask = { int(args.cpu) } affinity_mask = {args.cpu}
except: except:
print("Invalid cpu: " + args.cpu) print("Invalid cpu: " + args.cpu)
exit(1) exit(1)
@ -44,7 +43,7 @@ except:
if args.prio: if args.prio:
try: try:
param = os.sched_param(int(args.prio)) param = os.sched_param(args.prio)
os.sched_setscheduler(0, os.SCHED_FIFO, param) os.sched_setscheduler(0, os.SCHED_FIFO, param)
except: except:
print("Error setting priority") print("Error setting priority")