Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-27 06:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

media: cdns-csi2rx: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Uwe Kleine-König 2023-03-26 16:30:46 +02:00 committed by Hans Verkuil
parent a5a86c2ee0
commit bbb3f635b0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/platform/cadence/cdns-csi2rx.c
View File

@ -473,14 +473,12 @@ err_free_priv:
return ret; return ret;
} }
static int csi2rx_remove(struct platform_device *pdev) static void csi2rx_remove(struct platform_device *pdev)
{ {
struct csi2rx_priv *csi2rx = platform_get_drvdata(pdev); struct csi2rx_priv *csi2rx = platform_get_drvdata(pdev);
v4l2_async_unregister_subdev(&csi2rx->subdev); v4l2_async_unregister_subdev(&csi2rx->subdev);
kfree(csi2rx); kfree(csi2rx);
return 0;
} }
static const struct of_device_id csi2rx_of_table[] = { static const struct of_device_id csi2rx_of_table[] = {
@ -491,7 +489,7 @@ MODULE_DEVICE_TABLE(of, csi2rx_of_table);
static struct platform_driver csi2rx_driver = { static struct platform_driver csi2rx_driver = {
.probe = csi2rx_probe, .probe = csi2rx_probe,
.remove = csi2rx_remove, .remove_new = csi2rx_remove,
.driver = { .driver = {
.name = "cdns-csi2rx", .name = "cdns-csi2rx",