Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 12:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

exofs: Avoid using file_fsync()

Browse Source 
The use of file_fsync() in exofs_file_sync() is not necessary since it
does some extra stuff not used by exofs. Open code just the parts that
are currently needed.

TODO: Farther optimization can be done to sync the sb only on inode
update of new files, Usually the sb update is not needed in exofs.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
This commit is contained in:
Boaz Harrosh 2009-06-14 16:52:10 +03:00
parent 27d2e14919
commit baaf94cdc7
3 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/exofs/exofs.h
View File

@ -154,6 +154,9 @@ ino_t exofs_parent_ino(struct dentry *child);
int exofs_set_link(struct inode *, struct exofs_dir_entry *, struct page *,
struct inode *);
/* super.c */
int exofs_sync_fs(struct super_block *sb, int wait);
/*********************
* operation vectors *
*********************/

17
fs/exofs/file.c
View File

@ -45,16 +45,23 @@ static int exofs_file_fsync(struct file *filp, struct dentry *dentry,
{
int ret;
struct address_space *mapping = filp->f_mapping;
struct inode *inode = dentry->d_inode;
struct super_block *sb;
ret = filemap_write_and_wait(mapping);
if (ret)
return ret;
/*Note: file_fsync below also calles sync_blockdev, which is a no-op
* for exofs, but other then that it does sync_inode and
* sync_superblock which is what we need here.
*/
return file_fsync(filp, dentry, datasync);
/* sync the inode attributes */
ret = write_inode_now(inode, 1);
/* This is a good place to write the sb */
/* TODO: Sechedule an sb-sync on create */
sb = inode->i_sb;
if (sb->s_dirt)
exofs_sync_fs(sb, 1);
return ret;
}
static int exofs_flush(struct file *file, fl_owner_t id)

2
fs/exofs/super.c
View File

@ -198,7 +198,7 @@ static const struct export_operations exofs_export_ops;
/*
* Write the superblock to the OSD
*/
static int exofs_sync_fs(struct super_block *sb, int wait)
int exofs_sync_fs(struct super_block *sb, int wait)
{
struct exofs_sb_info *sbi;
struct exofs_fscb *fscb;