Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

afs: Fix missing/incorrect unlocking of RCU read lock

Browse Source 
In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both
places before returning (and not lock it again).

Fixes: f94f70d39c ("afs: Provide a way to configure address priorities")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@intel.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
This commit is contained in:
David Howells 2024-01-17 15:49:26 +00:00
parent cfcc005dbc
commit b904935053
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/afs/proc.c
View File

@ -166,7 +166,7 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v)
if (!preflist) { if (!preflist) {
seq_puts(m, "NO PREFS\n"); seq_puts(m, "NO PREFS\n");
return 0; goto out;
} }
seq_printf(m, "PROT SUBNET PRIOR (v=%u n=%u/%u/%u)\n", seq_printf(m, "PROT SUBNET PRIOR (v=%u n=%u/%u/%u)\n",
@ -191,7 +191,8 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v)
} }
} }
rcu_read_lock(); out:
rcu_read_unlock();
return 0; return 0;
} }