Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2025-01-01 15:51:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

ath6kl: Fix htc_packet leak in ath6kl_htc_rx_fetch()

Browse Source 
It is found during the code review. As the leak would happen only
in failure case, the imapct is not easily visible.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This commit is contained in:
Vasanthakumar Thiagarajan 2011-10-03 17:28:25 +05:30 committed by Kalle Valo
parent 4159cc935a
commit b8d5d5ff03
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/ath/ath6kl/htc.c
View File

@ -1715,12 +1715,10 @@ static int ath6kl_htc_rx_fetch(struct htc_target *target,
packet = list_first_entry(rx_pktq, struct htc_packet,
list);
list_del(&packet->list);
/* fully synchronous */
packet->completion = NULL;
if (!list_empty(rx_pktq))
if (!list_is_singular(rx_pktq))
/*
* look_aheads in all packet
* except the last one in the
@ -1735,7 +1733,7 @@ static int ath6kl_htc_rx_fetch(struct htc_target *target,
if (status)
return status;
list_add_tail(&packet->list, comp_pktq);
list_move_tail(&packet->list, comp_pktq);
}
}