mirror of
https://github.com/torvalds/linux.git
synced 2024-12-05 18:41:23 +00:00
mlxsw: core_env: Forbid module reset on RJ45 ports
Transceiver module reset through 'rst' field in PMAOS register is not supported on RJ45 ports, so module reset should be rejected. Therefore, before trying to access this field, validate the port module type that was queried during initialization and return an error to user space in case the port module type is RJ45 (twisted pair). Output example: # ethtool --reset swp11 phy ETHTOOL_RESET 0x40 Cannot issue ETHTOOL_RESET: Invalid argument $ dmesg mlxsw_spectrum 0000:03:00.0 swp11: Reset module is not supported on port module type Signed-off-by: Danielle Ratson <danieller@nvidia.com> Signed-off-by: Ido Schimmel <idosch@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
c8f994ccdd
commit
b7347cdf10
@ -467,6 +467,12 @@ int mlxsw_env_reset_module(struct net_device *netdev,
|
||||
|
||||
mutex_lock(&mlxsw_env->module_info_lock);
|
||||
|
||||
err = __mlxsw_env_validate_module_type(mlxsw_core, module);
|
||||
if (err) {
|
||||
netdev_err(netdev, "Reset module is not supported on port module type\n");
|
||||
goto out;
|
||||
}
|
||||
|
||||
if (mlxsw_env->module_info[module].num_ports_up) {
|
||||
netdev_err(netdev, "Cannot reset module when ports using it are administratively up\n");
|
||||
err = -EINVAL;
|
||||
|
Loading…
Reference in New Issue
Block a user