Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-28 07:01:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: rtl8712: fix boundary condition for n

Browse Source 
Now that snprintf is replaced by scnprintf n >= MAX_WPA_IE_LEN doesn't
make sense as the maximum value n can take is MAX_WPA_IE_LEN.

Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20191002170518.GA1688@SARKAR
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Rohit Sarkar 2019-10-02 22:35:19 +05:30 committed by Greg Kroah-Hartman
parent f8fcbb6ba8
commit b664312285
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rtl8712/rtl871x_ioctl_linux.c
View File

@ -144,7 +144,7 @@ static noinline_for_stack char *translate_scan_wpa(struct iw_request_info *info,
for (i = 0; i < wpa_len; i++) { for (i = 0; i < wpa_len; i++) {
n += scnprintf(buf + n, MAX_WPA_IE_LEN - n, n += scnprintf(buf + n, MAX_WPA_IE_LEN - n,
"%02x", wpa_ie[i]); "%02x", wpa_ie[i]);
if (n >= MAX_WPA_IE_LEN) if (n == MAX_WPA_IE_LEN-1)
break; break;
} }
memset(iwe, 0, sizeof(*iwe)); memset(iwe, 0, sizeof(*iwe));
@ -164,7 +164,7 @@ static noinline_for_stack char *translate_scan_wpa(struct iw_request_info *info,
for (i = 0; i < rsn_len; i++) { for (i = 0; i < rsn_len; i++) {
n += scnprintf(buf + n, MAX_WPA_IE_LEN - n, n += scnprintf(buf + n, MAX_WPA_IE_LEN - n,
"%02x", rsn_ie[i]); "%02x", rsn_ie[i]);
if (n >= MAX_WPA_IE_LEN) if (n == MAX_WPA_IE_LEN-1)
break; break;
} }
memset(iwe, 0, sizeof(*iwe)); memset(iwe, 0, sizeof(*iwe));