Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 20:22:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

kconfig: remove unneeded menu_is_visible() call in conf_write_defconfig()

Browse Source 
When the condition 'sym == NULL' is met, the code will reach the
'next_menu' label regardless of the return value from menu_is_visible().

menu_is_visible() calculates some symbol values as a side-effect, for
instance by calling expr_calc_value(menu->visibility), but all the
symbol values will be calculated eventually.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada 2024-03-10 23:16:17 +09:00
parent 4957515b9c
commit b27a91383a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/kconfig/confdata.c
View File

@ -799,10 +799,7 @@ int conf_write_defconfig(const char *filename)
while (menu != NULL) while (menu != NULL)
{ {
sym = menu->sym; sym = menu->sym;
if (sym == NULL) { if (sym && !sym_is_choice(sym)) {
if (!menu_is_visible(menu))
goto next_menu;
} else if (!sym_is_choice(sym)) {
sym_calc_value(sym); sym_calc_value(sym);
if (!(sym->flags & SYMBOL_WRITE)) if (!(sym->flags & SYMBOL_WRITE))
goto next_menu; goto next_menu;