Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-01 08:31:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

firmware: tegra: Fix error check return value of debugfs_create_file()

Browse Source 
If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR),
so use IS_ERR() to check it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Lv Ruyi 2022-04-19 01:36:48 +00:00 committed by Thierry Reding
parent a4740b148a
commit afcdb8e55c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/firmware/tegra/bpmp-debugfs.c
View File

@ -474,7 +474,7 @@ static int bpmp_populate_debugfs_inband(struct tegra_bpmp *bpmp,
mode |= attrs & DEBUGFS_S_IWUSR ? 0200 : 0; mode |= attrs & DEBUGFS_S_IWUSR ? 0200 : 0;
dentry = debugfs_create_file(name, mode, parent, bpmp, dentry = debugfs_create_file(name, mode, parent, bpmp,
&bpmp_debug_fops); &bpmp_debug_fops);
if (!dentry) { if (IS_ERR(dentry)) {
err = -ENOMEM; err = -ENOMEM;
goto out; goto out;
} }
@ -725,7 +725,7 @@ static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf *seqbuf,
if (t & DEBUGFS_S_ISDIR) { if (t & DEBUGFS_S_ISDIR) {
dentry = debugfs_create_dir(name, parent); dentry = debugfs_create_dir(name, parent);
if (!dentry) if (IS_ERR(dentry))
return -ENOMEM; return -ENOMEM;
err = bpmp_populate_dir(bpmp, seqbuf, dentry, depth+1); err = bpmp_populate_dir(bpmp, seqbuf, dentry, depth+1);
if (err < 0) if (err < 0)
@ -738,7 +738,7 @@ static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf *seqbuf,
dentry = debugfs_create_file(name, mode, dentry = debugfs_create_file(name, mode,
parent, bpmp, parent, bpmp,
&debugfs_fops); &debugfs_fops);
if (!dentry) if (IS_ERR(dentry))
return -ENOMEM; return -ENOMEM;
} }
} }
@ -788,11 +788,11 @@ int tegra_bpmp_init_debugfs(struct tegra_bpmp *bpmp)
return 0; return 0;
root = debugfs_create_dir("bpmp", NULL); root = debugfs_create_dir("bpmp", NULL);
if (!root) if (IS_ERR(root))
return -ENOMEM; return -ENOMEM;
bpmp->debugfs_mirror = debugfs_create_dir("debug", root); bpmp->debugfs_mirror = debugfs_create_dir("debug", root);
if (!bpmp->debugfs_mirror) { if (IS_ERR(bpmp->debugfs_mirror)) {
err = -ENOMEM; err = -ENOMEM;
goto out; goto out;
} }