Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-02 00:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

thermal/drivers/exynos: Use BIT wherever possible

Browse Source 
The original driver did not use that macro and it allows us to make our
intentions slightly clearer.

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20231201095625.301884-9-m.majewski2@samsung.com
This commit is contained in:
Mateusz Majewski 2023-12-01 10:56:24 +01:00 committed by Daniel Lezcano
parent b72ba67bae
commit af00d48833
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/thermal/samsung/exynos_tmu.c
View File

@ -388,7 +388,7 @@ static void exynos4412_tmu_set_trip_temp(struct exynos_tmu_data *data,
if (trip == 3) { if (trip == 3) {
con = readl(data->base + EXYNOS_TMU_REG_CONTROL); con = readl(data->base + EXYNOS_TMU_REG_CONTROL);
con |= (1 << EXYNOS_TMU_THERM_TRIP_EN_SHIFT); con |= BIT(EXYNOS_TMU_THERM_TRIP_EN_SHIFT);
writel(con, data->base + EXYNOS_TMU_REG_CONTROL); writel(con, data->base + EXYNOS_TMU_REG_CONTROL);
} }
} }
@ -559,16 +559,16 @@ static void exynos4210_tmu_control(struct platform_device *pdev, bool on)
continue; continue;
interrupt_en |= interrupt_en |=
(1 << (EXYNOS_TMU_INTEN_RISE0_SHIFT + i * 4)); BIT(EXYNOS_TMU_INTEN_RISE0_SHIFT + i * 4);
} }
if (data->soc != SOC_ARCH_EXYNOS4210) if (data->soc != SOC_ARCH_EXYNOS4210)
interrupt_en |= interrupt_en |=
interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
} else { } else {
con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
} }
writel(interrupt_en, data->base + EXYNOS_TMU_REG_INTEN); writel(interrupt_en, data->base + EXYNOS_TMU_REG_INTEN);
@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on)
continue; continue;
interrupt_en |= interrupt_en |=
(1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i)); BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
} }
interrupt_en |= interrupt_en |=
interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
} else } else
con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
pd_det_en = on ? EXYNOS5433_PD_DET_EN : 0; pd_det_en = on ? EXYNOS5433_PD_DET_EN : 0;
@ -622,17 +622,17 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on)
continue; continue;
interrupt_en |= interrupt_en |=
(1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i)); BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
} }
interrupt_en |= interrupt_en |=
interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT; interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT); con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
con |= (1 << EXYNOS7_PD_DET_EN_SHIFT); con |= BIT(EXYNOS7_PD_DET_EN_SHIFT);
} else { } else {
con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT); con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT); con &= ~BIT(EXYNOS7_PD_DET_EN_SHIFT);
} }
writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN); writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN);