mirror of
https://github.com/torvalds/linux.git
synced 2024-12-23 19:31:53 +00:00
usb: musb: omap: fix the error check for pm_runtime_get_sync
pm_runtime_get_sync returns a signed integer. In case of errors it returns a negative value. This patch fixes the error check by making it signed instead of unsigned thus preventing register access if get_sync_fails. Also passes the error cause to the debug message. Cc: stable@vger.kernel.org Cc: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
parent
8ae8090c82
commit
ad579699c4
@ -282,7 +282,8 @@ static void musb_otg_notifier_work(struct work_struct *data_notifier_work)
|
|||||||
|
|
||||||
static int omap2430_musb_init(struct musb *musb)
|
static int omap2430_musb_init(struct musb *musb)
|
||||||
{
|
{
|
||||||
u32 l, status = 0;
|
u32 l;
|
||||||
|
int status = 0;
|
||||||
struct device *dev = musb->controller;
|
struct device *dev = musb->controller;
|
||||||
struct musb_hdrc_platform_data *plat = dev->platform_data;
|
struct musb_hdrc_platform_data *plat = dev->platform_data;
|
||||||
struct omap_musb_board_data *data = plat->board_data;
|
struct omap_musb_board_data *data = plat->board_data;
|
||||||
@ -301,7 +302,7 @@ static int omap2430_musb_init(struct musb *musb)
|
|||||||
|
|
||||||
status = pm_runtime_get_sync(dev);
|
status = pm_runtime_get_sync(dev);
|
||||||
if (status < 0) {
|
if (status < 0) {
|
||||||
dev_err(dev, "pm_runtime_get_sync FAILED");
|
dev_err(dev, "pm_runtime_get_sync FAILED %d\n", status);
|
||||||
goto err1;
|
goto err1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user