mirror of
https://github.com/torvalds/linux.git
synced 2024-12-05 02:23:16 +00:00
[SCSI] libsas: fix ata list corruption issue
I think this stems from a misunderstanding of how the ata error handler works. ata_scsi_cmd_error_handler() gets called with a passed in list of commands to handle. However, that list may still not be empty when it exits. The command ata_scsi_port_error_handler() must be called (which takes no list) before the list will be completely emptied. This bites the sas error handler because the two are called from different functions and the original list has gone out of scope before ata_scsi_port_error_handler() is called. leading to some commands dangling on bare stack, which is a potential memory corruption issue. Fix this by manually deleting all outstanding commands from the on-stack list before it goes out of scope. Signed-off-by: James Bottomley <James.Bottomley@suse.de>
This commit is contained in:
parent
941b1cdae8
commit
a82058a730
@ -802,6 +802,19 @@ int sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,
|
||||
if (!list_empty(&sata_q)) {
|
||||
ata_port_printk(ap, KERN_DEBUG, "sas eh calling libata cmd error handler\n");
|
||||
ata_scsi_cmd_error_handler(shost, ap, &sata_q);
|
||||
/*
|
||||
* ata's error handler may leave the cmd on the list
|
||||
* so make sure they don't remain on a stack list
|
||||
* about to go out of scope.
|
||||
*
|
||||
* This looks strange, since the commands are
|
||||
* now part of no list, but the next error
|
||||
* action will be ata_port_error_handler()
|
||||
* which takes no list and sweeps them up
|
||||
* anyway from the ata tag array.
|
||||
*/
|
||||
while (!list_empty(&sata_q))
|
||||
list_del_init(sata_q.next);
|
||||
}
|
||||
} while (ap);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user