Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 12:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm: improve the documentation of connector hpd ops

Browse Source 
While making the changes in [1], it was noted that the documentation
of the enable_hpd() and disable_hpd() does not make it clear that
these ops should not try to do hpd state maintenance and should only
enable/disable hpd related hardware for the connector.

The state management of these calls to make sure these calls are
balanced is handled by the DRM core and we should keep it that way
to minimize the overhead in the drivers which implement these ops.

[1]: https://patchwork.freedesktop.org/patch/558387/

Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230920201358.27597-1-quic_abhinavk@quicinc.com
This commit is contained in:
Abhinav Kumar 2023-09-20 13:13:58 -07:00 committed by Dmitry Baryshkov
parent 5d86c15c31
commit a5b2dcb96d
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/drm/drm_modeset_helper_vtables.h
View File

@ -1154,6 +1154,11 @@ struct drm_connector_helper_funcs {
* This operation is optional. * This operation is optional.
* *
* This callback is used by the drm_kms_helper_poll_enable() helpers. * This callback is used by the drm_kms_helper_poll_enable() helpers.
*
* This operation does not need to perform any hpd state tracking as
* the DRM core handles that maintenance and ensures the calls to enable
* and disable hpd are balanced.
*
*/ */
void (*enable_hpd)(struct drm_connector *connector); void (*enable_hpd)(struct drm_connector *connector);
@ -1165,6 +1170,11 @@ struct drm_connector_helper_funcs {
* This operation is optional. * This operation is optional.
* *
* This callback is used by the drm_kms_helper_poll_disable() helpers. * This callback is used by the drm_kms_helper_poll_disable() helpers.
*
* This operation does not need to perform any hpd state tracking as
* the DRM core handles that maintenance and ensures the calls to enable
* and disable hpd are balanced.
*
*/ */
void (*disable_hpd)(struct drm_connector *connector); void (*disable_hpd)(struct drm_connector *connector);
}; };