Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-28 23:21:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools/x86/kcpuid: Properly align long-description columns

Browse Source 
When kcpuid is invoked with "--all --details", the detailed description
column is not properly aligned for all bitfield rows:

CPUID_0x4_ECX[0x0]:
	 cache_level        	: 0x1       	- Cache Level ...
	 cache_self_init     - Cache Self Initialization

This is due to differences in output handling between boolean single-bit
"bitflags" and multi-bit bitfields.  For the former, the bitfield's value
is not outputted as it is implied to be true by just outputting the
bitflag's name in its respective line.

If long descriptions were requested through the --all parameter, properly
align the bitflag's description columns through extra tabs.  With that,
the sample output above becomes:

CPUID_0x4_ECX[0x0]:
	 cache_level        	: 0x1       	- Cache Level ...
	 cache_self_init     			- Cache Self Initialization

Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240718134755.378115-3-darwi@linutronix.de
This commit is contained in:
Ahmed S. Darwish 2024-07-18 15:47:42 +02:00 committed by Thomas Gleixner
parent 39e470057f
commit a52e735f28
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/arch/x86/kcpuid/kcpuid.c
View File

@ -449,8 +449,9 @@ static void decode_bits(u32 value, struct reg_desc *rdesc, enum cpuid_reg reg)
if (start == end) { if (start == end) {
/* single bit flag */ /* single bit flag */
if (value & (1 << start)) if (value & (1 << start))
printf("\t%-20s %s%s\n", printf("\t%-20s %s%s%s\n",
bdesc->simp, bdesc->simp,
show_flags_only ? "" : "\t\t\t",
show_details ? "-" : "", show_details ? "-" : "",
show_details ? bdesc->detail : "" show_details ? bdesc->detail : ""
); );