Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-02 09:01:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

tty: sysrq: use switch in sysrq_key_table_key2index()

Browse Source 
Using switch with range cases makes the code more aligned and readable.
Expand also that 36 as explicit addition of 10 + 26 to make the source
of the constant more obvious.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230712081811.29004-5-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jiri Slaby 2023-07-12 10:18:05 +02:00 committed by Greg Kroah-Hartman
parent 8ac20a03da
commit a27f3b7233
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/tty/sysrq.c
View File

@ -532,17 +532,16 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
/* key2index calculation, -1 on invalid index */
static int sysrq_key_table_key2index(u8 key)
{
int retval;
if ((key >= '0') && (key <= '9'))
retval = key - '0';
else if ((key >= 'a') && (key <= 'z'))
retval = key + 10 - 'a';
else if ((key >= 'A') && (key <= 'Z'))
retval = key + 36 - 'A';
else
retval = -1;
return retval;
switch (key) {
case '0' ... '9':
return key - '0';
case 'a' ... 'z':
return key - 'a' + 10;
case 'A' ... 'Z':
return key - 'A' + 10 + 26;
default:
return -1;
}
}
/*