Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 22:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

PCI: iproc-msi: Fix __iomem annotation in decode_msi_hwirq()

Browse Source 
Fix __iomem attribute on msg variable passed to readl() in
the decode_msi_hwirq() function. Fixes the following sparse
warning:

drivers/pci/controller/pcie-iproc-msi.c:301:17: warning: incorrect type in argument 1 (different address spaces)
drivers/pci/controller/pcie-iproc-msi.c:301:17:    expected void const volatile [noderef] <asn:2> *addr
drivers/pci/controller/pcie-iproc-msi.c:301:17:    got unsigned int [usertype] *[assigned] msg

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Andrew Murray <andrew.murray@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
This commit is contained in:
Ben Dooks (Codethink) 2019-10-15 17:07:02 +01:00 committed by Lorenzo Pieralisi
parent 54ecb8f702
commit a243bf39d8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/pci/controller/pcie-iproc-msi.c
View File

@ -293,11 +293,12 @@ static const struct irq_domain_ops msi_domain_ops = {
static inline u32 decode_msi_hwirq(struct iproc_msi *msi, u32 eq, u32 head) static inline u32 decode_msi_hwirq(struct iproc_msi *msi, u32 eq, u32 head)
{ {
u32 *msg, hwirq; u32 __iomem *msg;
u32 hwirq;
unsigned int offs; unsigned int offs;
offs = iproc_msi_eq_offset(msi, eq) + head * sizeof(u32); offs = iproc_msi_eq_offset(msi, eq) + head * sizeof(u32);
msg = (u32 *)(msi->eq_cpu + offs); msg = (u32 __iomem *)(msi->eq_cpu + offs);
hwirq = readl(msg); hwirq = readl(msg);
hwirq = (hwirq >> 5) + (hwirq & 0x1f); hwirq = (hwirq >> 5) + (hwirq & 0x1f);