Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-02 00:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

tracing: fix comments about trace buffer resizing

Browse Source 
Impact: cleanup

Some of the comments about the trace buffer resizing is gobbledygook.
And I wonder why people question if I'm a native English speaker.

This patch makes the comments make a bit more sense.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
This commit is contained in:
Steven Rostedt 2009-03-12 11:21:08 -04:00
parent 51b643b404
commit a123c52b46
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
kernel/trace/trace.c
View File

@ -2336,7 +2336,8 @@ static int tracing_resize_ring_buffer(unsigned long size)
/* /*
* If kernel or user changes the size of the ring buffer * If kernel or user changes the size of the ring buffer
* it get completed. * we use the size that was given, and we can forget about
* expanding it later.
*/ */
ring_buffer_expanded = 1; ring_buffer_expanded = 1;
@ -2351,8 +2352,20 @@ static int tracing_resize_ring_buffer(unsigned long size)
r = ring_buffer_resize(global_trace.buffer, r = ring_buffer_resize(global_trace.buffer,
global_trace.entries); global_trace.entries);
if (r < 0) { if (r < 0) {
/* AARGH! We are left with different /*
* size max buffer!!!! */ * AARGH! We are left with different
* size max buffer!!!!
* The max buffer is our "snapshot" buffer.
* When a tracer needs a snapshot (one of the
* latency tracers), it swaps the max buffer
* with the saved snap shot. We succeeded to
* update the size of the main buffer, but failed to
* update the size of the max buffer. But when we tried
* to reset the main buffer to the original size, we
* failed there too. This is very unlikely to
* happen, but if it does, warn and kill all
* tracing.
*/
WARN_ON(1); WARN_ON(1);
tracing_disabled = 1; tracing_disabled = 1;
} }