Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-10-26 23:12:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

USB: misc/vstusb, fix lock imbalance

Browse Source 
Make sure we don't leak locked vstdev->lock in vstusb_write. Unlock
properly on one fail path.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jiri Slaby 2009-03-11 21:47:39 +01:00 committed by Greg Kroah-Hartman
parent 46c9844c40
commit a08b43aee4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/misc/vstusb.c
View File

@ -401,6 +401,7 @@ static ssize_t vstusb_write(struct file *file, const char __user *buffer,
} }
if (copy_from_user(buf, buffer, count)) { if (copy_from_user(buf, buffer, count)) {
mutex_unlock(&vstdev->lock);
dev_err(&dev->dev, "%s: can't copy_from_user\n", __func__); dev_err(&dev->dev, "%s: can't copy_from_user\n", __func__);
retval = -EFAULT; retval = -EFAULT;
goto exit; goto exit;