From 9f3199bcef11caff5e935d0565de0bdb73a3798e Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Fri, 5 Jan 2018 07:22:52 +0000 Subject: [PATCH] um: vector: fix missing unlock on error in vector_net_open() Add the missing unlock before return from function vector_net_open() in the error handling case. Fixes: ad1f62ab2bd4 ("High Performance UML Vector Network Driver") Signed-off-by: Wei Yongjun Signed-off-by: Richard Weinberger --- arch/um/drivers/vector_kern.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index d1d53015d572..bb83a2d22ac2 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -1156,8 +1156,10 @@ static int vector_net_open(struct net_device *dev) struct vector_device *vdevice; spin_lock_irqsave(&vp->lock, flags); - if (vp->opened) + if (vp->opened) { + spin_unlock_irqrestore(&vp->lock, flags); return -ENXIO; + } vp->opened = true; spin_unlock_irqrestore(&vp->lock, flags);