mirror of
https://github.com/torvalds/linux.git
synced 2024-11-02 02:01:29 +00:00
mx3fb: use display information in info not in var for panning
We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Also use the aligned fix.line_length and not the (possible) unaligned xres_virtual. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
This commit is contained in:
parent
23dc8b1c07
commit
9f1b3ebbce
@ -1062,15 +1062,15 @@ static int mx3fb_pan_display(struct fb_var_screeninfo *var,
|
||||
y_bottom = var->yoffset;
|
||||
|
||||
if (!(var->vmode & FB_VMODE_YWRAP))
|
||||
y_bottom += var->yres;
|
||||
y_bottom += fbi->var.yres;
|
||||
|
||||
if (y_bottom > fbi->var.yres_virtual)
|
||||
return -EINVAL;
|
||||
|
||||
mutex_lock(&mx3_fbi->mutex);
|
||||
|
||||
offset = (var->yoffset * var->xres_virtual + var->xoffset) *
|
||||
(var->bits_per_pixel / 8);
|
||||
offset = var->yoffset * fbi->fix.line_length
|
||||
+ var->xoffset * (fbi->var.bits_per_pixel / 8);
|
||||
base = fbi->fix.smem_start + offset;
|
||||
|
||||
dev_dbg(fbi->device, "Updating SDC BG buf %d address=0x%08lX\n",
|
||||
|
Loading…
Reference in New Issue
Block a user