Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-21 19:41:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

scripts: sphinx-pre-install: remove unnecessary double check for $cur_version

Browse Source 
$cur_version is currently being tested twice with the first test
resulting in an unhelpful "$sphinx returned an error", not continuing to
the more helpful "$sphinx didn't return its version".

This patch removes the first test to return the more useful message.

Fixes: a8b380c379 ("scripts: sphinx-pre-install: only ask to activate valid venvs")
Signed-off-by: Sebastian Muxel <sebastian@muxel.dev>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20240827133224.160776-1-sebastian@muxel.dev
This commit is contained in:
Sebastian Muxel 2024-08-27 15:32:24 +02:00 committed by Jonathan Corbet
parent bc6cb62007
commit 9b8a79f4c1
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/sphinx-pre-install
View File

@ -300,8 +300,6 @@ sub check_sphinx()
} }
$cur_version = get_sphinx_version($sphinx); $cur_version = get_sphinx_version($sphinx);
die ("$sphinx returned an error") if (!$cur_version);
die "$sphinx didn't return its version" if (!$cur_version); die "$sphinx didn't return its version" if (!$cur_version);
if ($cur_version lt $min_version) { if ($cur_version lt $min_version) {